From 6f95e6ba98d5e26d0c92710a4c197aadd876b08a Mon Sep 17 00:00:00 2001 From: Jonas Amundsen Date: Sat, 12 Dec 2020 13:24:36 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=A4=96=20Merge=20PR=20#49630=20mssql:=20m?= =?UTF-8?q?ake=20database=20of=20config=20optional=20by=20@badeball?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The property is inherently optional and has to be omitted when eg. working with mssql when a database has yet to be created. --- types/mssql/index.d.ts | 2 +- types/mssql/mssql-tests.ts | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/types/mssql/index.d.ts b/types/mssql/index.d.ts index 45b320a459..c3e557e599 100644 --- a/types/mssql/index.d.ts +++ b/types/mssql/index.d.ts @@ -194,7 +194,7 @@ export interface config { server: string; port?: number; domain?: string; - database: string; + database?: string; connectionTimeout?: number; requestTimeout?: number; stream?: boolean; diff --git a/types/mssql/mssql-tests.ts b/types/mssql/mssql-tests.ts index 5d7e09c98e..b887999ea8 100644 --- a/types/mssql/mssql-tests.ts +++ b/types/mssql/mssql-tests.ts @@ -24,6 +24,8 @@ var config: sql.config = { } } +var minimalConfig: sql.config = { server: 'ip' }; + var connectionStringTest: sql.ConnectionPool = new sql.ConnectionPool("connectionstring", (err) => { if (err) { return err;