From caad3f0aabaad827e6beaa3290b82c3bbe1f58b7 Mon Sep 17 00:00:00 2001 From: dev-nicolaos Date: Mon, 27 Dec 2021 23:31:49 -0800 Subject: [PATCH] =?UTF-8?q?=F0=9F=A4=96=20Merge=20PR=20#57811=20connect-ti?= =?UTF-8?q?meout=20accepts=20numbers=20for=20delay=20by=20@dev-nicolaos?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * connect-timeout accepts numbers for delay * add test * Update types/connect-timeout/index.d.ts Co-authored-by: Adam Jones Co-authored-by: Adam Jones --- types/connect-timeout/connect-timeout-tests.ts | 10 ++++++++++ types/connect-timeout/index.d.ts | 5 ++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/types/connect-timeout/connect-timeout-tests.ts b/types/connect-timeout/connect-timeout-tests.ts index 31342d7491..606592c391 100644 --- a/types/connect-timeout/connect-timeout-tests.ts +++ b/types/connect-timeout/connect-timeout-tests.ts @@ -21,3 +21,13 @@ function haltOnTimedout(req: express.Request, res: express.Response, next: Funct } app.listen(3000); + +// check use of number as delay +var app2 = express(); +app2.use(timeout(500)); +app2.use(bodyParser()); +app2.use(haltOnTimedout); +app2.use(cookieParser()); +app2.use(haltOnTimedout); + +app2.listen(3001); diff --git a/types/connect-timeout/index.d.ts b/types/connect-timeout/index.d.ts index 621cf81400..acc98f68e0 100644 --- a/types/connect-timeout/index.d.ts +++ b/types/connect-timeout/index.d.ts @@ -37,6 +37,9 @@ declare module "connect-timeout" { } } - function e(timeout: string, options?: e.TimeoutOptions): express.RequestHandler; + /** + * @summary Returns middleware that times out in time milliseconds. time can also be a string accepted by the ms module. On timeout, req will emit "timeout". + */ + function e(time: number | string, options?: e.TimeoutOptions): express.RequestHandler; export = e; }