From 989515ff2876935fe7afe15ee9de55464eed0ad2 Mon Sep 17 00:00:00 2001 From: Chen Asraf Date: Tue, 9 Dec 2025 01:28:15 +0200 Subject: [PATCH] fix: show defaults log only when actually applying defaults --- installer/installer.go | 8 ++++++++ installer/installer_defaults.go | 2 -- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/installer/installer.go b/installer/installer.go index eaa93bc..d9558e8 100644 --- a/installer/installer.go +++ b/installer/installer.go @@ -137,6 +137,14 @@ func RunInstaller(config *appconfig.AppConfig, installer IInstaller) error { info := installer.GetData() name := *info.Name curOS := platform.GetPlatform() + + // Log if defaults were applied for this installer type + if config.Defaults != nil && config.Defaults.Type != nil { + if _, ok := (*config.Defaults.Type)[info.Type]; ok { + logger.Debug("Applying defaults for %s", info.Type) + } + } + logger.Debug("Checking if %s (%s) should run on %s", name, info.Type, curOS) env := config.Environ() if !installer.GetData().Platforms.GetShouldRunOnOS(curOS) { diff --git a/installer/installer_defaults.go b/installer/installer_defaults.go index a4f04af..6c7fbfa 100644 --- a/installer/installer_defaults.go +++ b/installer/installer_defaults.go @@ -2,7 +2,6 @@ package installer import ( "github.com/chenasraf/sofmani/appconfig" - "github.com/chenasraf/sofmani/logger" "github.com/chenasraf/sofmani/platform" "maps" ) @@ -20,7 +19,6 @@ func InstallerWithDefaults( // per-type overrides from defaults if defaults != nil && defaults.Type != nil { if override, ok := (*defaults.Type)[installerType]; ok { - logger.Debug("Applying defaults for %s", installerType) if override.Opts != nil { source := *override.Opts target := *data.Opts