casraf/DefinitelyTyped-tools
1
0
Fork 0
mirror of https://github.com/chenasraf/DefinitelyTyped-tools.git synced 2026-05-18 01:49:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Format

Browse Source
This commit is contained in:
TypeScript Bot
2021-05-13 16:31:34 +00:00
parent 4dcf82b758
commit 4bdab7de7d
2 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/definitions-parser/src/git.ts
View File

@@ -180,16 +180,15 @@ When removing packages, you should only delete files that are a part of removed
)
);
return mapDefined(deletedPackages, p => {
const hasTyping = allPackages.hasTypingFor({ name: p, version: "*" })
const notNeeded = allPackages.getNotNeededPackage(p)
const hasTyping = allPackages.hasTypingFor({ name: p, version: "*" });
const notNeeded = allPackages.getNotNeededPackage(p);
if (hasTyping) {
if (notNeeded) {
throw new Error(`Please delete all files in ${p} when adding it to notNeededPackages.json.`);
}
return undefined
}
else {
return notNeeded;
return undefined;
} else {
return notNeeded;
}
});
}

8
packages/definitions-parser/test/git.test.ts
View File

@@ -39,7 +39,9 @@ testo({
);
},
deleteInOtherPackage() {
expect(getNotNeededPackages(allPackages, [...deleteJestDiffs, { status: "D", file: "types/most-recent/extra-tests.ts" }])).toEqual(jestNotNeeded);
expect(
getNotNeededPackages(allPackages, [...deleteJestDiffs, { status: "D", file: "types/most-recent/extra-tests.ts" }])
).toEqual(jestNotNeeded);
},
extraneousFile() {
expect(
@@ -49,7 +51,7 @@ testo({
{ status: "D", file: "types/jest/index.d.ts" },
{ status: "D", file: "types/jest/jest-tests.d.ts" }
])
).toEqual(jestNotNeeded)
).toEqual(jestNotNeeded);
},
scoped() {
expect(
@@ -57,7 +59,7 @@ testo({
AllPackages.from(typesData, [new NotNeededPackage("ember__object", "@ember/object", "1.0.0")]),
[{ status: "D", file: "types/ember__object/index.d.ts" }]
)
).toEqual([new NotNeededPackage("ember__object", "@ember/object", "1.0.0")])
).toEqual([new NotNeededPackage("ember__object", "@ember/object", "1.0.0")]);
}
// TODO: Test npm info (and with scoped names)
// TODO: Test with dependents, etc etc