casraf/DefinitelyTyped-tools
1
0
Fork 0
mirror of https://github.com/chenasraf/DefinitelyTyped-tools.git synced 2026-05-18 01:49:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Allow <reference /> to self in UMD tests (#714)

Browse Source 
* fix: Allow `<reference />` to self in UMD tests

* fix: Disallow `<reference />` to self in module files that only export
This commit is contained in:
ExE Boss
2019-12-03 18:30:48 +01:00
committed by Andrew Branch
parent 592470a647
commit 7c69e944f6
1 changed files with 24 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
packages/types-publisher/src/lib/module-info.ts
View File

@@ -346,6 +346,10 @@ export function getTestDependencies(
const sourceFile = createSourceFile(filename, content);
const { fileName, referencedFiles, typeReferenceDirectives } = sourceFile;
const filePath = () => path.join(packageName, fileName);
let hasImports = false;
let isModule = false;
let referencesSelf = false;
for (const { fileName: ref } of referencedFiles) {
throw new Error(`Test files should not use '<reference path="" />'. '${filePath()}' references '${ref}'.`);
}
@@ -355,11 +359,12 @@ export function getTestDependencies(
`'${filePath()}' unnecessarily references '${referencedPackage}', which is already referenced in the type definition.`);
}
if (referencedPackage === packageName) {
throw new Error(`'${filePath()}' unnecessarily references the package. This can be removed.`);
referencesSelf = true;
}
testDependencies.add(referencedPackage);
}
for (const imported of imports(sourceFile)) {
hasImports = true;
if (!imported.startsWith(".")) {
const dep = rootName(imported, typeFiles);
if (!dependencies.has(dep) && dep !== packageName) {
@@ -367,6 +372,24 @@ export function getTestDependencies(
}
}
}
isModule = hasImports || (() => {
// FIXME: This results in files without imports to be walked twice,
// once in the `imports(...)` function, and once more here:
for (const node of sourceFile.statements) {
if (
node.kind === ts.SyntaxKind.ExportAssignment ||
node.kind === ts.SyntaxKind.ExportDeclaration
) {
return true;
}
}
return false;
})();
if (isModule && referencesSelf) {
throw new Error(`'${filePath()}' unnecessarily references the package. This can be removed.`);
}
}
return testDependencies;
}