casraf/DefinitelyTyped-tools
1
0
Fork 0
mirror of https://github.com/chenasraf/DefinitelyTyped-tools.git synced 2026-05-17 17:48:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix RC installation (#678)

Browse Source 
* Fix RC installation

Fixes #677
See that bug for discussion; it's somewhat complicated, but the fix is:
during RC you have to install the RC as well, just in case.

* add explanatory comment (that is good)
This commit is contained in:
Nathan Shively-Sanders
2023-05-19 11:59:10 -07:00
committed by GitHub
parent 8eb317e7ad
commit 941589930b
1 changed files with 15 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
packages/utils/src/typescript-installer.ts
View File

@@ -14,6 +14,10 @@ export async function installAllTypeScriptVersions() {
for (const v of TypeScriptVersion.shipped) {
await install(v);
}
// `shipped + [rc, next] == supported` during the RC period. During that time, typescript@rc needs to be installed too.
if (TypeScriptVersion.shipped.length + 2 === TypeScriptVersion.supported.length) {
await install("rc");
}
await installTypeScriptNext();
}
@@ -21,7 +25,7 @@ export async function installTypeScriptNext() {
await install("next");
}
async function install(version: TsVersion | "next"): Promise<void> {
async function install(version: TsVersion | "next" | "rc"): Promise<void> {
if (version === "local") {
return;
}
@@ -29,7 +33,14 @@ async function install(version: TsVersion | "next"): Promise<void> {
if (!(await fs.pathExists(dir))) {
console.log(`Installing to ${dir}...`);
await fs.mkdirp(dir);
await fs.writeJson(path.join(dir, "package.json"), packageJson(version));
await fs.writeJson(path.join(dir, "package.json"), {
description: `Installs typescript@${version}`,
repository: "N/A",
license: "MIT",
dependencies: {
typescript: version,
},
});
await execAndThrowErrors("npm install --ignore-scripts --no-shrinkwrap --no-package-lock --no-bin-links", dir);
console.log("Installed!");
console.log("");
@@ -47,9 +58,10 @@ export function typeScriptPath(version: TsVersion, tsLocal: string | undefined):
return path.join(installDir(version), "node_modules", "typescript");
}
function installDir(version: TsVersion | "next"): string {
function installDir(version: TsVersion | "next" | "rc"): string {
assert(version !== "local");
if (version === "next") version = TypeScriptVersion.latest;
if (version === "rc") version = TypeScriptVersion.supported[TypeScriptVersion.supported.length - 2];
return path.join(installsDir, version);
}
@@ -74,14 +86,3 @@ async function execAndThrowErrors(cmd: string, cwd?: string): Promise<void> {
});
});
}
function packageJson(version: TsVersion | "next"): {} {
return {
description: `Installs typescript@${version}`,
repository: "N/A",
license: "MIT",
dependencies: {
typescript: version,
},
};
}