casraf/DefinitelyTyped-tools
1
0
Fork 0
mirror of https://github.com/chenasraf/DefinitelyTyped-tools.git synced 2026-05-18 01:49:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix dtslint build again (#357)

Browse Source 
1. Use Error casts instead of type annotations to any.
2. Somehow stricter settings didn't apply to dtslint before.
3. Use tsc -b . in dtslint and dts-critic's `build` script.
This commit is contained in:
Nathan Shively-Sanders
2021-12-01 11:29:21 -08:00
committed by GitHub
parent b6cea6a5b4
commit ec84740915
12 changed files with 20 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/definitions-parser/src/lib/settings.ts
View File

@@ -26,7 +26,7 @@ export const getAllowedPackageJsonDependencies = withCache(60 * 60 * 1000, () =>
} catch (err) {
console.error(
"Getting the latest allowedPackageJsonDependencies.txt from GitHub failed. Falling back to local copy.\n" +
err.message
(err as Error).message
);
}
}

2
packages/dts-critic/develop.ts
View File

@@ -169,7 +169,7 @@ function doCheck(args: {
const errors = dtsCritic(dtsPath, /* sourcePath */ undefined, opts, args.debug);
return { package: args.package, output: errors };
} catch (e) {
return { package: args.package, output: e.toString() };
return { package: args.package, output: (e as Error).toString() };
}
}

1
packages/dts-critic/index.test.ts
View File

@@ -1,3 +1,4 @@
/// <reference types="jest" />
import {
findDtsName,
getNpmInfo,

3
packages/dts-critic/index.ts
View File

@@ -309,9 +309,6 @@ export function findDtsName(dtsPath: string) {
return path.basename(path.dirname(resolved));
}
/** Default path to store packages downloaded from npm. */
const sourceDir = path.resolve(path.join(__dirname, "..", "sources"));
/** Returns path of downloaded npm package. */
function downloadNpmPackage(name: string, version: string, outDir: string): string {
const npmName = dtToNpmName(name);

2
packages/dts-critic/package.json
View File

@@ -33,7 +33,7 @@
"types": "dist/index.d.ts",
"scripts": {
"test": "npm run build && jest",
"build": "tsc",
"build": "tsc -b .",
"dt": "node dist/dt.js",
"prepublishOnly": "npm run build && npm run test"
},

1
packages/dts-critic/tsconfig.json
View File

@@ -6,6 +6,7 @@
"resolveJsonModule": true,
"outDir": "dist",
"declaration": true,
"types": ["jest"]
},
"exclude": [
"dist/*",

2
packages/dtslint/package.json
View File

@@ -24,7 +24,7 @@
},
"scripts": {
"watch": "tsc --watch",
"build": "tsc",
"build": "tsc -b .",
"lint": "eslint --ext ts src",
"test": "npm run build && node test/test.js",
"prepublishOnly": "npm run build && npm run test && npm run lint"

2
packages/dtslint/src/rules/noUnnecessaryGenericsRule.ts
View File

@@ -89,7 +89,7 @@ function getSoleUse(sig: ts.SignatureDeclaration, typeParameterSymbol: ts.Symbol
return soleUse ? { type: "sole", soleUse } : { type: "never" };
function recur(node: ts.TypeNode): void {
function recur(node: ts.Node): void {
if (ts.isIdentifier(node)) {
if (checker.getSymbolAtLocation(node) === typeParameterSymbol) {
if (soleUse === undefined) {

2
packages/dtslint/src/suggestions.ts
View File

@@ -47,7 +47,7 @@ export function addSuggestion<T>(ctx: WalkContext<T>, message: string, start?: n
{ flag, encoding: "utf8" }
);
} catch (e) {
console.log(`Could not write suggestions for package ${packageName}. ${e.message || ""}`);
console.log(`Could not write suggestions for package ${packageName}. ${(e as Error).message || ""}`);
}
}

6
packages/publisher/src/publish-packages.ts
View File

@@ -43,7 +43,7 @@ if (!module.parent) {
);
} catch (e) {
// log and continue
log("publishing to github failed: " + e.toString());
log("publishing to github failed: " + (e as Error).toString());
}
await deprecateNotNeededPackage(
await NpmPublishClient.create(await getSecret(Secret.NPM_TOKEN), undefined, Registry.NPM),
@@ -89,7 +89,7 @@ export default async function publishPackages(
await publishTypingsPackage(ghClient, cp, dry, log, Registry.Github);
} catch (e) {
// log and continue
log("publishing to github failed: " + e.toString());
log("publishing to github failed: " + (e as Error).toString());
}
await publishTypingsPackage(client, cp, dry, log, Registry.NPM);
@@ -179,7 +179,7 @@ export default async function publishPackages(
await publishNotNeededPackage(ghClient, target, dry, log, Registry.Github);
} catch (e) {
// log and continue
log("publishing to github failed: " + e.toString());
log("publishing to github failed: " + (e as Error).toString());
}
await publishNotNeededPackage(client, target, dry, log, Registry.NPM);
}

2
packages/publisher/src/publish-registry.ts
View File

@@ -83,7 +83,7 @@ export default async function publishRegistry(
await publishToRegistry(RegistryName.Github);
} catch (e) {
// log and continue
log("publishing to github failed: " + e.toString());
log("publishing to github failed: " + (e as Error).toString());
}
await publishToRegistry(RegistryName.NPM);
await writeLog("publish-registry.md", logResult());

16
packages/utils/src/process.ts
View File

@@ -161,7 +161,7 @@ export function runWithListeningChildProcesses<In extends Serializable>({
}
}
} catch (e) {
onError(e);
onError(e as Error);
}
};
@@ -218,7 +218,7 @@ export function runWithListeningChildProcesses<In extends Serializable>({
assert.fail(`${processIndex}> Unexpected crashRecoveryState: ${crashRecoveryState}`);
}
} catch (e) {
onError(e);
onError(e as Error);
}
};
@@ -233,7 +233,7 @@ export function runWithListeningChildProcesses<In extends Serializable>({
child = fork(workerFile, commandLineArgs, { cwd, execArgv: await getChildProcessExecArgv(i, execArgv) });
runningChildren.add(child);
} catch (e) {
fail(e);
fail(e as Error);
return;
}
@@ -262,7 +262,7 @@ export function runWithListeningChildProcesses<In extends Serializable>({
child.on("error", onError);
taskAction();
} catch (e) {
onError(e);
onError(e as Error);
}
};
@@ -279,7 +279,7 @@ export function runWithListeningChildProcesses<In extends Serializable>({
child.removeAllListeners();
child.kill();
} catch (e) {
onError(e);
onError(e as Error);
}
};
@@ -290,7 +290,7 @@ export function runWithListeningChildProcesses<In extends Serializable>({
stopChild(/*done*/ false);
await startChild(taskAction, execArgv);
} catch (e) {
onError(e);
onError(e as Error);
}
};
@@ -299,7 +299,7 @@ export function runWithListeningChildProcesses<In extends Serializable>({
assert(runningChildren.has(child), `${processIndex}> Child not running`);
child.send(currentInput);
} catch (e) {
onError(e);
onError(e as Error);
}
};
@@ -313,7 +313,7 @@ export function runWithListeningChildProcesses<In extends Serializable>({
}
child.send(currentInput);
} catch (e) {
onError(e);
onError(e as Error);
}
};