🤖 Merge PR #64274 [glider-js] Add removeEventListener methods by @martin-badin

Co-authored-by: Martin Badin <MBadin@gohealth.com>
This commit is contained in:
martin-badin
2023-02-09 06:43:23 +01:00
committed by GitHub
parent 55f7ef15c4
commit e9daf07cc6
2 changed files with 29 additions and 2 deletions

View File

@@ -138,7 +138,7 @@ if (element) {
event.target;
if (event.target) {
// $ExpectType Glider<HTMLDivElement> | undefined
// $ExpectType Glider<HTMLElement> | undefined
event.target._glider;
}
});
@@ -158,6 +158,21 @@ if (element) {
event;
});
element.removeEventListener('glider-refresh', event => {
// $ExpectType GliderEvent<undefined>
event;
// $ExpectType boolean
event.bubbles;
event.target;
if (event.target) {
// $ExpectType Glider<HTMLElement> | undefined
event.target._glider;
}
});
Glider(element).setOption({ draggable: true });
Glider(element).refresh();

View File

@@ -13,7 +13,7 @@ declare namespace Glider {
interface GliderEvent<T = undefined> extends Event {
detail: T;
target: (HTMLElement & { _glider: Glider | undefined }) | null;
target: (HTMLElement & { _glider: Glider<HTMLElement> | undefined }) | null;
}
interface GliderEventMap {
@@ -287,6 +287,12 @@ declare global {
listener: (event: Glider.GliderEvent<Glider.GliderEventMap[K]>) => void,
options?: boolean | AddEventListenerOptions,
): void;
removeEventListener<K extends keyof Glider.GliderEventMap>(
type: K,
listener: (event: Glider.GliderEvent<Glider.GliderEventMap[K]>) => void,
options?: boolean | AddEventListenerOptions,
): void;
}
interface HTMLDivElement {
@@ -295,6 +301,12 @@ declare global {
listener: (event: Glider.GliderEvent<Glider.GliderEventMap[K]>) => void,
options?: boolean | AddEventListenerOptions,
): void;
removeEventListener<K extends keyof Glider.GliderEventMap>(
type: K,
listener: (event: Glider.GliderEvent<Glider.GliderEventMap[K]>) => void,
options?: boolean | AddEventListenerOptions,
): void;
}
}