casraf/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/chenasraf/DefinitelyTyped.git synced 2026-05-18 01:49:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: gulp-connect tests use gulp.task callback correctly (#50118)

Browse Source 
* fix: gulp-connect tests use gulp.task callback correctly

Previously, `gulp.task` allowed a callback to return anything. Now it's
based on the `async-done`'s `AsyncTask`. I'm pretty sure the correct
change is to make the callback async, based on that type.

* Don't return anything from a sync callback

Based on reading the gulp-connect examples, which use sync callbacks and
no returns
This commit is contained in:
Nathan Shively-Sanders
2020-12-14 10:02:32 -08:00
committed by GitHub
parent 4cf53efec1
commit faeb84348a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
types/gulp-connect/gulp-connect-tests.ts
View File

@@ -96,7 +96,7 @@ gulp.task('connect', () => {
express()
];
return connect.server({
connect.server({
root: [__dirname],
port: 8081,
livereload: true,
@@ -112,7 +112,7 @@ gulp.task('connect', () => {
["/path2", express()],
];
return connect.server({
connect.server({
root: [__dirname],
port: 8081,
livereload: true,