casraf/sofmani
1
0
Fork 0
mirror of https://github.com/chenasraf/sofmani.git synced 2026-05-17 17:28:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(logs): remove unnecessary group logs

Browse Source
This commit is contained in:
Chen Asraf
2026-05-15 20:26:57 +03:00
parent 017d9a7299
commit f5b077ef89
1 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
installer/installer.go
View File

@@ -193,6 +193,11 @@ func RunInstaller(config *appconfig.AppConfig, installer IInstaller) (*summary.I
Type: string(info.Type),
}
// Group installers fully delegate work to their children; the group's own
// install/update/check lifecycle is a no-op wrapper, so suppress the
// per-step Info logs and let the children speak for themselves.
isDelegating := info.Type == appconfig.InstallerTypeGroup
// Set skip summary flags if configured
if info.SkipSummary != nil {
result.SkipSummaryInstall = info.SkipSummary.Install
@@ -284,13 +289,17 @@ func RunInstaller(config *appconfig.AppConfig, installer IInstaller) (*summary.I
logger.Debug("%s: %s is already installed", logger.H(string(info.Type)), logger.H(name))
if *config.CheckUpdates {
logger.Info("Checking updates for %s: %s", logger.H(string(info.Type)), logger.H(name))
if !isDelegating {
logger.Info("Checking updates for %s: %s", logger.H(string(info.Type)), logger.H(name))
}
needsUpdate, err := installer.CheckNeedsUpdate()
if err != nil {
return nil, err
}
if needsUpdate {
logger.Info("Updating %s", logger.H(name))
if !isDelegating {
logger.Info("Updating %s", logger.H(name))
}
if info.PreUpdate != nil {
logger.Debug("Running pre-update command for %s", logger.H(name))
err := utils.RunCmdPassThrough(env, utils.GetOSShell(installer.GetData().EnvShell), utils.GetOSShellArgs(applyTmpl(*info.PreUpdate))...)
@@ -312,14 +321,18 @@ func RunInstaller(config *appconfig.AppConfig, installer IInstaller) (*summary.I
}
result.Action = summary.ActionUpgraded
} else {
logger.Info("%s: %s is up-to-date", logger.H(string(info.Type)), logger.H(name))
if !isDelegating {
logger.Info("%s: %s is up-to-date", logger.H(string(info.Type)), logger.H(name))
}
result.Action = summary.ActionUpToDate
}
} else {
result.Action = summary.ActionUpToDate
}
} else {
logger.Info("Installing %s: %s", logger.H(string(installer.GetData().Type)), logger.H(name))
if !isDelegating {
logger.Info("Installing %s: %s", logger.H(string(installer.GetData().Type)), logger.H(name))
}
if info.PreInstall != nil {
logger.Debug("Running pre-install command for %s: %s", logger.H(string(info.Type)), logger.H(name))
err := utils.RunCmdPassThrough(env, utils.GetOSShell(installer.GetData().EnvShell), utils.GetOSShellArgs(applyTmpl(*info.PreInstall))...)