casraf/DefinitelyTyped-tools
1
0
Fork 0
mirror of https://github.com/chenasraf/DefinitelyTyped-tools.git synced 2026-05-18 01:49:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove parallelism from npm install (#715)

Browse Source 
* Remove parallelism from npm install

I'm not sure this will prevent errors in @types/node PRs, but it should
help.

* fix closure-conversion mistake
This commit is contained in:
Nathan Shively-Sanders
2019-12-09 15:50:06 -08:00
committed by Andrew Branch
parent 7c69e944f6
commit 30c9ff02a5
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/types-publisher/src/tester/test-runner.ts
View File

@@ -14,7 +14,7 @@ import { AllPackages, DependencyVersion, PackageId, TypingsData, NotNeededPackag
import { UncachedNpmInfoClient, NpmInfo } from "../lib/npm-client";
import { npmInstallFlags } from "../util/io";
import { consoleLogger, Logger, LoggerWithErrors, loggerWithErrors } from "../util/logging";
import { assertDefined, exec, execAndThrowErrors, flatMap, joinPaths, logUncaughtErrors, mapIter, nAtATime, numberOfOsProcesses, runWithListeningChildProcesses, CrashRecoveryState } from "../util/util";
import { assertDefined, exec, execAndThrowErrors, flatMap, joinPaths, logUncaughtErrors, mapIter, numberOfOsProcesses, runWithListeningChildProcesses, CrashRecoveryState } from "../util/util";
import { getAffectedPackages, allDependencies } from "./get-affected-packages";
@@ -72,7 +72,7 @@ export default async function runTests(
console.log(`Running with ${nProcesses} processes.`);
const typesPath = `${definitelyTypedPath}/types`;
await doInstalls(allPackages, [...changedPackages, ...dependentPackages], typesPath, nProcesses);
await doInstalls(allPackages, [...changedPackages, ...dependentPackages], typesPath);
console.log("Testing...");
await doRunTests([...changedPackages, ...dependentPackages], new Set(changedPackages), typesPath, nProcesses);
@@ -137,14 +137,14 @@ it is supposed to replace, ${latestTypings.versionString} of ${unneeded.fullNpmN
assert(source.versions.has(unneeded.version.versionString), `The specified version ${unneeded.version.versionString} of ${unneeded.libraryName} is not on npm.`);
}
async function doInstalls(allPackages: AllPackages, packages: Iterable<TypingsData>, typesPath: string, nProcesses: number): Promise<void> {
async function doInstalls(allPackages: AllPackages, packages: Iterable<TypingsData>, typesPath: string): Promise<void> {
console.log("Installing NPM dependencies...");
// We need to run `npm install` for all dependencies, too, so that we have dependencies' dependencies installed.
await nAtATime(nProcesses, allDependencies(allPackages, packages), async pkg => {
for (const pkg of allDependencies(allPackages, packages)) {
const cwd = directoryPath(typesPath, pkg);
if (!await pathExists(joinPaths(cwd, "package.json"))) {
return;
continue;
}
// Scripts may try to compile native code.
@@ -156,7 +156,7 @@ async function doInstalls(allPackages: AllPackages, packages: Iterable<TypingsDa
// Must specify what this is for since these run in parallel.
console.log(` from ${cwd}: ${stdout}`);
}
});
}
await runCommand(console, undefined, require.resolve("dtslint"), ["--installAll"]);
}